Text of github.com › golang › go › issues › 25744 as Styx crawled it on Nov 19, 2026. The page may have changed since. Only its words are kept, without pictures or layout.

Open the live page

x/build/maintner: new empty milestones are not detected · Issue #25744 · golang/go · GitHub

Skip to content You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session. Dismiss alert x/build/maintner: new empty milestones are not detected #25744 New issue Copy link New issue Copy link Open Open x/build/maintner: new empty milestones are not detected #25744 Copy link Labels Builders x/build issues (builders, bots, dashboards) x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Milestone Unreleased Description FiloSottile opened on Jun 6, 2018 Issue body actions A new milestone with no issues does not show up in the corpus. (Also, don't mind me while I use this issue to prime the corpus.) Reacted by Katie Hockman, Dmitri Shuralyov and Andy Bonventre Activity Next gopherbot added this to the Unreleased milestone on Jun 6, 2018 gopherbot added Builders x/build issues (builders, bots, dashboards) x/build issues (builders, bots, dashboards) on Jun 6, 2018 FiloSottile modified the milestones: Unreleased , Go1.10.4 , Go1.9.8 on Jun 6, 2018 dmitshur commented on Sep 7, 2018 dmitshur on Sep 7, 2018 Member More actions I ran into what I suspect to be a related issue while doing #26949 .

A newly added GitHub repository with zero issues does not show up in the corpus. As soon as I created the first Pull Request (which counts as an issue), the repository showed up: 1. added "dl" to whitelist ( CL x ) and redeployed maintnerd 2. corpus . GitHub (). Repo ( "golang" , "dl" ) // nil 3. created first issue / PR in the repo https : //github.com/golang/dl/pull/1 4. corpus . GitHub (). Repo ( "golang" , "dl" ) // non-nil (Thanks @FiloSottile for reporting this issue; if I hadn't seen it, it would've been harder for me to debug what went wrong.) Details To test this, I used maintserve .

I also ran the following snippet: package main import ( "context" "fmt" "log" "golang.org/x/build/maintner" "golang.org/x/build/maintner/godata" ) func main () { corpus , err := godata . Get ( context . Background ()) if err != nil { log . Fatalln ( err ) } num := make ( map [ string ] int ) for _ , name := range [] string { "example" , "dl" } { repo := corpus . GitHub (). Repo ( "golang" , name ) if repo == nil { continue } err = repo .

ForeachIssue ( func ( gi * maintner. GitHubIssue ) error { num [ name ] ++ return nil }) if err != nil { log . Println ( err ) } } fmt . Println ( num ) } Before first PR: map[example:11] After first PR: map[example:11 dl:1] Edit: That said, I don't think this is necessarily a bad behavior that must be changed. Perhaps the right fix is documentation. I'd need to think through the trade-offs before making a decision. katiehockman modified the milestones: Unreleased , Go1.11.2 on Oct 1, 2018 katiehockman commented on Oct 2, 2018 katiehockman on Oct 2, 2018 Contributor More actions After going through the latest Go release, I think this is indeed a bug.

If a new, empty milestone is not picked up by the corpus, then the new milestone for the next release will be ignored. The current code will then require that some random issue is added to this future milestone in order to be picked up and allow the release to proceed. I also used this issue to prime the corpus as @FiloSottile did, but that feels like a bit of a hack. FiloSottile modified the milestone: Go1.10.8 on Dec 14, 2018 202 remaining items Load more actions mknyszek added this to the Go1.16.10 milestone on Oct 7, 2021 dmitshur modified the milestones: Go1.16.10 , Unreleased on Oct 12, 2021 dmitshur modified the milestones: Unreleased , go1.18 , Go1.17.7 on Dec 15, 2021 dmitshur modified the milestones: Unreleased , Go1.19.14 on Mar 19, 2024 Sign up for free to join this conversation on GitHub.

Already have an account? Sign in to comment Metadata Metadata Assignees No one assigned Labels Builders x/build issues (builders, bots, dashboards) x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Type No type Projects No projects Milestone Unreleased Relationships None yet Development No branches or pull requests Issue actions You can’t perform that action at this time.