[Patch] Patch for fontmanager crash - matplotlib-users - Matplotlib
[Patch] Patch for fontmanager crash Community matplotlib-users _Nicolas_Mailhot July 8, 2013, 2:57pm 1 Hi, In matplotlib 1.2.1, the get_name function is not garding against none self (unlike other functions); Unfortunately it seems I have a workload that makes matplotlib call get_name with None (wasn't the case in 1.2.0). I couldn't isolate the exact trigger, when I reduce the volume of data processed the problem goes away so I have to simple shareable reproducer.
Anyway, the following patch makes it all work for me, could it (or something similar) be merged? diff -uNr matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py matplotlib-1.2.1/lib/matplotlib/font_manager.py --- matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py 2013-03-26 14:04:37.000000000 +0100 +++ matplotlib-1.2.1/lib/matplotlib/font_manager.py 2013-07-08 14:49:37.791845661 +0200 @@ -721,6 +721,8 @@ Return the name of the font that best matches the font properties.
""" + if self._family is None: + return rcParams['font.family'] return ft2font.FT2Font(str(findfont(self))).family_name def get_style(self): Regards, ··· -- Nicolas Mailhot Martin_Mokrejs1 July 8, 2013, 4:18pm 2 Nicolas Mailhot wrote: Hi, In matplotlib 1.2.1, the get_name function is not garding against none self (unlike other functions); Unfortunately it seems I have a workload that makes matplotlib call get_name with None (wasn't the case in 1.2.0).
I couldn't isolate the exact trigger, when I reduce the volume of data processed the problem goes away so I have to simple shareable reproducer. Anyway, the following patch makes it all work for me, could it (or something similar) be merged? diff -uNr matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py matplotlib-1.2.1/lib/matplotlib/font_manager.py --- matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py 2013-03-26 14:04:37.000000000 +0100 +++ matplotlib-1.2.1/lib/matplotlib/font_manager.py 2013-07-08 14:49:37.791845661 +0200 @@ -721,6 +721,8 @@ Return the name of the font that best matches the font properties.
""" + if self._family is None: + return rcParams['font.family'] return ft2font.FT2Font(str(findfont(self))).family_name def get_style(self): Regards, Could you instead just test for "if not self._family"? Tests for equality are more expensive (that means self._family == 0 or self._family == False will also trigger your return). _Nicolas_Mailhot July 9, 2013, 1:14pm 3 I can test if it works. However, all the other tests in that file are already of the if Foo is None form, and I didn't want to change the coding style Regards, ··· Le Lun 8 juillet 2013 18:18, Martin Mokrejs a écrit : Nicolas Mailhot wrote: Hi, In matplotlib 1.2.1, the get_name function is not garding against none self (unlike other functions); Unfortunately it seems I have a workload that makes matplotlib call get_name with None (wasn't the case in 1.2.0).
I couldn't isolate the exact trigger, when I reduce the volume of data processed the problem goes away so I have to simple shareable reproducer. Anyway, the following patch makes it all work for me, could it (or something similar) be merged? diff -uNr matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py matplotlib-1.2.1/lib/matplotlib/font_manager.py --- matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py 2013-03-26 14:04:37.000000000 +0100 +++ matplotlib-1.2.1/lib/matplotlib/font_manager.py 2013-07-08 14:49:37.791845661 +0200 @@ -721,6 +721,8 @@ Return the name of the font that best matches the font properties.
""" + if self._family is None: + return rcParams['font.family'] return ft2font.FT2Font(str(findfont(self))).family_name def get_style(self): Regards, Could you instead just test for "if not self._family"? Tests for equality are more expensive (that means self._family == 0 or self._family == False will also trigger your return). -- Nicolas Mailhot _Nicolas_Mailhot July 9, 2013, 2:30pm 4 And I can confirm the following patch also fixes my workload diff -uNr matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py matplotlib-1.2.1/lib/matplotlib/font_manager.py --- matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py 2013-03-26 14:04:37.000000000 +0100 +++ matplotlib-1.2.1/lib/matplotlib/font_manager.py 2013-07-08 14:49:37.791845661 +0200 @@ -721,6 +721,8 @@ Return the name of the font that best matches the font properties.
""" + if not self._family: + return rcParams['font.family'][0] return ft2font.FT2Font(str(findfont(self))).family_name def get_style(self): Now could something similar be merged? Regards, ··· Le Mar 9 juillet 2013 15:14, Nicolas Mailhot a écrit : Le Lun 8 juillet 2013 18:18, Martin Mokrejs a écrit : Could you instead just test for "if not self._family"? Tests for equality are more expensive (that means self._family == 0 or self._family == False will also trigger your return).
I can test if it works. However, all the other tests in that file are already of the if Foo is None form, and I didn't want to change the coding style -- Nicolas Mailhot Martin_Mokrejs1 July 9, 2013, 3:03pm 5 Hi Nicolas, Nicolas Mailhot wrote: Could you instead just test for "if not self._family"? Tests for equality are more expensive (that means self._family == 0 or self._family == False will also trigger your return).
I can test if it works. However, all the other tests in that file are already of the if Foo is None form, and I didn't want to change the coding style I think it is a bad style then. If in some places a '' or False is needed to discriminate from None then the code should be changed. And I can confirm the following patch also fixes my workload diff -uNr matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py matplotlib-1.2.1/lib/matplotlib/font_manager.py --- matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py 2013-03-26 14:04:37.000000000 +0100 +++ matplotlib-1.2.1/lib/matplotlib/font_manager.py 2013-07-08 14:49:37.791845661 +0200 @@ -721,6 +721,8 @@ Return the name of the font that best matches the font properties.
""" + if not self._family: + return rcParams['font.family'][0] return ft2font.FT2Font(str(findfont(self))).family_name def get_style(self): Now could something similar be merged? Thank you for your efforts on this. I am just a user like you so we have to wait for an answer of the maintainers. Maybe I should have emphasized that earlier. But this is good for the community review anyway. Martin ··· Le Mar 9 juillet 2013 15:14, Nicolas Mailhot a écrit : Le Lun 8 juillet 2013 18:18, Martin Mokrejs a écrit : Michael_Droettboom1 July 17, 2013, 1:04pm 6 This patch doesn't make a whole lot of sense to me. get_name should work just fine if self._family is None, and indeed it does in my own testing: from matplotlib import font_manager f = font_manager.FontProperties(None) print f._family print f.get_family() print f.get_name() So I'd much prefer to get to the bottom of the root cause of this problem than patch it unnecessarily in this way.
Any idea what that is? Mike ··· On 07/08/2013 10:57 AM, Nicolas Mailhot wrote: Hi, In matplotlib 1.2.1, the get_name function is not garding against none self (unlike other functions); Unfortunately it seems I have a workload that makes matplotlib call get_name with None (wasn't the case in 1.2.0). I couldn't isolate the exact trigger, when I reduce the volume of data processed the problem goes away so I have to simple shareable reproducer.
Anyway, the following patch makes it all work for me, could it (or something similar) be merged? diff -uNr matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py matplotlib-1.2.1/lib/matplotlib/font_manager.py --- matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py 2013-03-26 14:04:37.000000000 +0100 +++ matplotlib-1.2.1/lib/matplotlib/font_manager.py 2013-07-08 14:49:37.791845661 +0200 @@ -721,6 +721,8 @@ Return the name of the font that best matches the font properties.
""" + if self._family is None: + return rcParams['font.family'] return ft2font.FT2Font(str(findfont(self))).family_name def get_style(self): Regards, _Nicolas_Mailhot July 18, 2013,
The rest of this page is on the live site.