Text of github.com › curl › curl › issues › 150 as Styx crawled it on Nov 18, 2026. The page may have changed since. Only its words are kept, without pictures or layout.

Open the live page

Completion of error handling · Issue #150 · curl/curl · GitHub

Skip to content You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session. Dismiss alert Completion of error handling #150 New issue Copy link New issue Copy link Closed Closed Completion of error handling #150 Copy link Assignees Description elfring opened on Mar 6, 2015 Issue body actions I have looked at a few source files for your current software.

I have noticed that some checks for return codes are missing. Would you like to add more error handling for return values from functions like the following? fseek ⇒ vms_realfilesize malloc ⇒ new_metalink_resource strdup ⇒ parse_cert_parameter Activity bagder added a commit that references this issue on Mar 6, 2015 metalink: add some error checks 3ac3331 bagder self-assigned this on Mar 6, 2015 bagder commented on Mar 6, 2015 bagder on Mar 6, 2015 Member More actions vms_realwfilesize() doesn't have any fseek calls.

I assume you mean the ones in operate_do(). I consider them mostly harmless. The same goes for the parse_cert_parameter strdups. The metalink function was improved slightly in commit 3ac3331 . elfring commented on Mar 6, 2015 elfring on Mar 6, 2015 Contributor Author More actions I suggest to avoid ignorance of return values a bit more. Are you interested to apply aspect-oriented software development ? How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software? bagder commented on Mar 6, 2015 bagder on Mar 6, 2015 Member More actions Can you identify any actual problems or bugs due to your discoveries?

Can you submit a patch with your suggested fixes? elfring commented on Mar 6, 2015 elfring on Mar 6, 2015 Contributor Author More actions How do you think about to improve static source code analysis also for your software? Do you find information sources like the following useful? Article " A Reusable Aspect for Memory Allocation Checking " Document " Aspect-Oriented Software Development - An Introduction " by Johan Brichau and Theo D'Hondt Paper " On Typesafe Aspect Implementations in C++ " by Daniel Lohmann and Olaf Spinczyk bagder commented on Mar 6, 2015 bagder on Mar 6, 2015 Member More actions Does that mean you can't identify a problem or provide a patch? evert commented on Mar 6, 2015 evert on Mar 6, 2015 More actions No, he wants to have a long-winded argument about software architecture! elfring commented on Mar 6, 2015 elfring on Mar 6, 2015 Contributor Author More actions The suggested tools can help to transform source code in various ways.

Which transformations are acceptable for you to be performed by another software tool automatically? bagder commented on Mar 6, 2015 bagder on Mar 6, 2015 Member More actions No bug then. Closed. bagder closed this as completed on Mar 6, 2015 lock locked as resolved and limited conversation to collaborators on May 7, 2018 Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment Metadata Metadata Assignees bagder Labels No labels No labels Type No type Projects No projects Milestone No milestone Relationships None yet Development No branches or pull requests Issue actions You can’t perform that action at this time.